Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove enabled field in loki-local-config.yaml #15059

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix: remove enabled field in loki-local-config.yaml #15059

merged 1 commit into from
Nov 25, 2024

Conversation

chenrui333
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #15039

relates to Homebrew/homebrew-core#198450

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@chenrui333 chenrui333 requested a review from a team as a code owner November 21, 2024 20:37
@CLAassistant
Copy link

CLAassistant commented Nov 21, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

trevorwhitney
trevorwhitney approved these changes Nov 23, 2024
View reviewed changes
Copy link
Collaborator

@trevorwhitney trevorwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@DylanGuedes DylanGuedes merged commit 7410f10 into grafana:main Nov 25, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DylanGuedes DylanGuedes DylanGuedes approved these changes

@trevorwhitney trevorwhitney trevorwhitney approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[3.3.0] loki-local-config.yaml#L41 causing startup failure
4 participants
@chenrui333 @CLAassistant @trevorwhitney @DylanGuedes