feat(helm): Helm support OpenStack application credentials for Swift storage #13266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/helm
type/docs
|
From what I could see in the code I believe the arguments should go into the gopher cloud module as written and the Please let me know if I've missed something though. |
heytrav
force-pushed
the
openstack-application-credentials
branch
6 times, most recently
from
e245062
to
3ffe635
Compare
heytrav
changed the title
heytrav
force-pushed
the
openstack-application-credentials
branch
3 times, most recently
from
e79e66a
to
fe2e367
Compare
heytrav
changed the title
heytrav
force-pushed
the
openstack-application-credentials
branch
4 times, most recently
from
23c76a6
to
b9cf0ff
Compare
heytrav
force-pushed
the
openstack-application-credentials
branch
9 times, most recently
from
12ef0fc
to
277df65
Compare
heytrav
force-pushed
the
openstack-application-credentials
branch
from
277df65
to
2033cc2
Compare
heytrav
force-pushed
the
openstack-application-credentials
branch
3 times, most recently
from
dc66e11
to
b7d06e9
Compare
heytrav
force-pushed
the
openstack-application-credentials
branch
2 times, most recently
from
24e587f
to
03ec13d
Compare
heytrav
force-pushed
the
openstack-application-credentials
branch
3 times, most recently
from
ae84365
to
8d334e6
Compare
|
Is there something I still need to do to get this reviewed? |
heytrav
force-pushed
the
openstack-application-credentials
branch
3 times, most recently
from
223ba0c
to
1e50be8
Compare
heytrav
force-pushed
the
openstack-application-credentials
branch
from
1e50be8
to
9421c70
Compare
heytrav
force-pushed
the
openstack-application-credentials
branch
9 times, most recently
from
2910590
to
c763e53
Compare
heytrav
force-pushed
the
openstack-application-credentials
branch
5 times, most recently
from
8e71b23
to
59af389
Compare
heytrav
force-pushed
the
openstack-application-credentials
branch
from
59af389
to
c308537
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Support application credentials for authentication with OpenStack.
Which issue(s) this PR fixes:
#14034
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR