Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _helpers.tpl #340

Closed
wants to merge 1 commit into from
Closed

Update _helpers.tpl #340

wants to merge 1 commit into from

Conversation

shahid430
Copy link

Changed namespace from default to monitoring

Changed namespace from default to monitoring
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -89,7 +89,7 @@ Create the name of the service account to use
{{- end -}}

{{- define "k6-operator.namespace" -}}
{{- if eq .Release.Namespace "default" }}
{{- if eq .Release.Namespace "monitoring" }}
Copy link
Contributor

@illrill illrill Nov 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This helper template is designed to default the installation into {{ .Release.Name }}-system instead of Helm's default choice of default, in the scenario that the user doesn't specify any namespace using helm install --namespace.

This change would mean that if a user does specify monitoring as the desired namespace, the installation instead goes into {{ .Release.Name }}-system. In contrast, if a user doesn't specify any namespace, the installation goes into default (which is what this helper template meant to prevent). This chart would basically become installable in any namespace except for monitoring.

@yorugac
Copy link
Collaborator

yorugac commented Nov 28, 2023

@shahid430, thanks for the PR but it's indeed not clear what this fix is for: unless specified, namespace will be %v-system as is defined here:
https://github.com/grafana/k6-operator/blob/main/charts/k6-operator/templates/_helpers.tpl#L93

@illrill Thanks for helping out 😄

@yorugac
Copy link
Collaborator

yorugac commented Dec 7, 2023

@shahid430 I'm closing this PR due to reasons stated above. Please feel free to re-open / open a new one if there's something else!

@yorugac yorugac closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants