Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a TestRun CRD as a duplicate of K6 CRD #286

Merged
merged 6 commits into from
Sep 25, 2023
Merged

Conversation

yorugac
Copy link
Collaborator

@yorugac yorugac commented Sep 13, 2023

Issue: #226

With these changes, both kind: K6 and kind: TestRun will be supported and will share the same logic. This is done as a transition period for everyone because K6 CRD will be removed in the future.

@yorugac yorugac force-pushed the feat/k6-crd-rename branch 2 times, most recently from 1e2d59e to bfe014e Compare September 19, 2023 11:07
@yorugac
Copy link
Collaborator Author

yorugac commented Sep 22, 2023

Additional changes in this PR include:

  • separate: false for PLZ test runs
  • PLZ CRD has now resources formatted according to Kubernetes conventions, expecting resources.limits to be defined. resources.requests can also be defined as part of PLZ (then they will be passed to each PLZ test run along with limits) but that is optional.

cc @dgzlopes

@yorugac
Copy link
Collaborator Author

yorugac commented Sep 25, 2023

Deprecation warning for K6 CRD requires resolving #273 at last.

@yorugac yorugac merged commit 88f9c9b into main Sep 25, 2023
9 checks passed
@yorugac yorugac deleted the feat/k6-crd-rename branch September 25, 2023 14:07
@yorugac yorugac added this to the 0.11 milestone Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant