Fix dockerfile user and remove k8s cluster domain suffix from status url #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorugac
requested changes
Jun 13, 2023
There was a problem hiding this comment.
Hi @dkhachyan, my apologies for the late reply. Thank you for noticing the Dockerfile.starter issue: nice catch! I have a couple of small requests; please see the comments.
dkhachyan
force-pushed
the
fix-dockerfile
branch
3 times, most recently
from
7f63ea5
to
92aeed8
Compare
|
Btw, "k8s cluster domain suffix" was preliminary fixed in another PR and shouldn't be an issue anymore 👍 |
dkhachyan
force-pushed
the
fix-dockerfile
branch
from
f07f399
to
48c4eae
Compare
dkhachyan
force-pushed
the
fix-dockerfile
branch
from
48c4eae
to
b6efae7
Compare
yorugac
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cluster.local.