-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GCP Compute Engine dashboard #1336
Conversation
3886059
to
1863b74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a fe comments...
Also for consistency with the azure dashboard, can you rename the instance_name, project_id and job column of Instances table to be: Instance, Project ID, Job for example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few observations, suggestions, and questions. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few comments...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few comments that I resume here:
- Why instance count is in red?
- Can you show Top Instance by Disk read bytes first and write after?
- On the table can you show first Disk read and write and then Network in and Out? It’s just to have same order in GCP and Azure. And also to have the same order you use on the breakdown panels below. Also rename the column titles with a shorter value that can be visible like Disk read bytes | Disk write bytes, Network received, Network sent?
- Can you rename Total packets count sent/recieved to something shorter like just “Total packets sent/recieved”?
- Can you rename Memory Utilization second word in lowercase?
- Can you rename Network throughput Sent/Received to just “Network sent/received”?
- Can you rename Total Bytes count read/write to just “Disk bytes (total)” or Disk read/write (bytes) or Disk read/write (total)? Using Total and count together is a bit confusing for a title. Also you are already displaying on the legend the Read and Write. Not sure if we should include them also in the title.
- Can you rename “Count of disk read bytes” to something shorter like “Disk read bytes (total)”? You can also omit total if you want. Same for operations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeahhhhh great work Ana. Thank you so much for taking care of my comments.
a5871b7
to
8351109
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just one little nit about the color on the top stat panels. @yduartep caught me on this on the azure queue store dashboard, and I linked to how I solved it there.
Great work, and thank you for all the thrash addressing feedback!
Thank you all for the feedback! I learned a lot from you while learning this library! |
Add GCP Compute Engine dashboard