Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GCP Compute Engine dashboard #1336

Merged
merged 35 commits into from
Sep 27, 2024
Merged

Add GCP Compute Engine dashboard #1336

merged 35 commits into from
Sep 27, 2024

Conversation

anaivanov
Copy link
Member

Add GCP Compute Engine dashboard

csp-mixin/panels.libsonnet Outdated Show resolved Hide resolved
Copy link
Contributor

@yduartep yduartep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a fe comments...

Also for consistency with the azure dashboard, can you rename the instance_name, project_id and job column of Instances table to be: Instance, Project ID, Job for example.

csp-mixin/signals/gcpce.libsonnet Outdated Show resolved Hide resolved
csp-mixin/signals/gcpce.libsonnet Outdated Show resolved Hide resolved
csp-mixin/signals/gcpceOverview.libsonnet Outdated Show resolved Hide resolved
csp-mixin/signals/gcpceOverview.libsonnet Outdated Show resolved Hide resolved
csp-mixin/signals/gcpceOverview.libsonnet Outdated Show resolved Hide resolved
csp-mixin/signals/gcpceOverview.libsonnet Outdated Show resolved Hide resolved
@yduartep
Copy link
Contributor

I don't know if there is something wrong with the table Instances by the values are not being rendered:
Screenshot 2024-09-23 at 18 52 01

@yduartep
Copy link
Contributor

On this panel, you have defined unit=short but then on the override cell, you have defined. unit=/s.

Screenshot 2024-09-23 at 18 56 25

@yduartep
Copy link
Contributor

yduartep commented Sep 23, 2024

On the second query of this panel, you are using a wrong query. It should be stackdriver_gce_instance_compute_googleapis_com_instance_network_received_bytes_count. For that reason the Received in the legend is not shown.

Screenshot 2024-09-23 at 18 58 58

@yduartep
Copy link
Contributor

yduartep commented Sep 23, 2024

If I use all the filters on this query, the graph is correctly shown. Now says No data.

Screenshot 2024-09-23 at 19 02 06

Same with the Network sent panel.
Screenshot 2024-09-23 at 19 03 02

@yduartep
Copy link
Contributor

yduartep commented Sep 23, 2024

Why don't you show Network Received and Network sent on the same line and show CPU Usage time and Cpu utilization on the same line? Same with Count on DIsk red/write and operations read/write. I think people use to read horizontally not vertically.
Screenshot 2024-09-23 at 19 03 41

csp-mixin/panels.libsonnet Outdated Show resolved Hide resolved
Copy link
Contributor

@rgeyer rgeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few observations, suggestions, and questions. :)

csp-mixin/panels.libsonnet Outdated Show resolved Hide resolved
csp-mixin/signals/gcpce.libsonnet Outdated Show resolved Hide resolved
csp-mixin/signals/gcpceOverview.libsonnet Show resolved Hide resolved
csp-mixin/signals/gcpceOverview.libsonnet Outdated Show resolved Hide resolved
Copy link
Contributor

@yduartep yduartep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few comments...

csp-mixin/signals/gcpceOverview.libsonnet Outdated Show resolved Hide resolved
csp-mixin/signals/gcpceOverview.libsonnet Show resolved Hide resolved
csp-mixin/panels.libsonnet Outdated Show resolved Hide resolved
csp-mixin/signals/gcpce.libsonnet Outdated Show resolved Hide resolved
csp-mixin/signals/gcpce.libsonnet Show resolved Hide resolved
csp-mixin/signals/gcpce.libsonnet Outdated Show resolved Hide resolved
csp-mixin/signals/gcpceOverview.libsonnet Outdated Show resolved Hide resolved
csp-mixin/signals/gcpceOverview.libsonnet Outdated Show resolved Hide resolved
csp-mixin/signals/gcpceOverview.libsonnet Show resolved Hide resolved
Copy link
Contributor

@yduartep yduartep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few comments that I resume here:

  • Why instance count is in red?
  • Can you show Top Instance by Disk read bytes first and write after?
  • On the table can you show first Disk read and write and then Network in and Out? It’s just to have same order in GCP and Azure. And also to have the same order you use on the breakdown panels below. Also rename the column titles with a shorter value that can be visible like Disk read bytes | Disk write bytes, Network received, Network sent?
  • Can you rename Total packets count sent/recieved to something shorter like just “Total packets sent/recieved”?
  • Can you rename Memory Utilization second word in lowercase?
  • Can you rename Network throughput Sent/Received to just “Network sent/received”?
  • Can you rename Total Bytes count read/write to just “Disk bytes (total)” or Disk read/write (bytes) or Disk read/write (total)? Using Total and count together is a bit confusing for a title. Also you are already displaying on the legend the Read and Write. Not sure if we should include them also in the title.
  • Can you rename “Count of disk read bytes” to something shorter like “Disk read bytes (total)”? You can also omit total if you want. Same for operations.

csp-mixin/panels.libsonnet Outdated Show resolved Hide resolved
csp-mixin/panels.libsonnet Outdated Show resolved Hide resolved
csp-mixin/panels.libsonnet Outdated Show resolved Hide resolved
csp-mixin/panels.libsonnet Outdated Show resolved Hide resolved
csp-mixin/panels.libsonnet Outdated Show resolved Hide resolved
csp-mixin/signals/gcpceOverview.libsonnet Outdated Show resolved Hide resolved
csp-mixin/signals/gcpceOverview.libsonnet Outdated Show resolved Hide resolved
csp-mixin/signals/gcpceOverview.libsonnet Outdated Show resolved Hide resolved
csp-mixin/signals/gcpceOverview.libsonnet Outdated Show resolved Hide resolved
csp-mixin/signals/gcpceOverview.libsonnet Outdated Show resolved Hide resolved
@anaivanov anaivanov marked this pull request as ready for review September 26, 2024 12:37
@anaivanov anaivanov requested a review from a team as a code owner September 26, 2024 12:37
Copy link
Contributor

@yduartep yduartep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeahhhhh great work Ana. Thank you so much for taking care of my comments.

Copy link
Contributor

@rgeyer rgeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one little nit about the color on the top stat panels. @yduartep caught me on this on the azure queue store dashboard, and I linked to how I solved it there.

Great work, and thank you for all the thrash addressing feedback!

image

csp-mixin/panels.libsonnet Outdated Show resolved Hide resolved
@anaivanov
Copy link
Member Author

Thank you all for the feedback! I learned a lot from you while learning this library!

@anaivanov anaivanov merged commit 349a4d4 into master Sep 27, 2024
3 checks passed
@anaivanov anaivanov deleted the ana/add-gcp-ce-dashboard branch September 27, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants