define new gcp and azure load balancer dashboard in csp-mixin #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgeyer
reviewed
Aug 30, 2024
There was a problem hiding this comment.
Couple comments which should hopefully answer the questions you had.
These are exactly the reason(s) why I need to do some organization, and possibly break this into a few different repositories/mixins. At the moment there are some odd workarounds for things that I did not initially plan for.
yduartep
changed the title
rgeyer
approved these changes
Sep 9, 2024
| @@ -1,7 +1,7 @@ | |||
| { | |||
| _config+:: { | |||
| local this = self, | |||
| dashboardTags: ['azure'], | |||
| dashboardTags: ['azure-cloud-provider'], | |||
There was a problem hiding this comment.
This will change the tags used by the other azure dashboards that are generated by this lib as well. We'll probably want/need to increment versions appropriately when we integrate it downstream.
There was a problem hiding this comment.
yeah, As you can see on next images, GCP and Azure use the same tag name.
Comment on lines
+9
to
+10
| [sig]: commonlib.signals.unmarshallJsonMulti(this.config.signals[sig], type=this.config.metricsSource) | ||
| for sig in std.objectFields(this.config.signals) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
define new gcp load balancer dashboard in csp-mixin
Check generated dashboards here: