Varnish k8s plugin support
#1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caleb-Hurshman
suggested changes
Jul 16, 2024
BominRahmani
approved these changes
Jul 17, 2024
algchoo
force-pushed
the
feat/varnish-k8s-support
branch
from
9f59c3d
to
bf8ad4b
Compare
Dasomeone
reviewed
Jul 19, 2024
Dasomeone
approved these changes
Jul 22, 2024
…the nature of log collection
auto-merge was automatically disabled
July 22, 2024 18:31
Head branch was pushed to by a user without write access
algchoo
force-pushed
the
feat/varnish-k8s-support
branch
from
942d85a
to
0122f4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Varnish mixin to support the
k8spluginLogs for this integration required sidecar forwarding and having
alloyread from an actual file on the container's filesystem, rather than reading logs from the container'sstdout. With this, even though it'sk8swe're still going to have afilenamelabel and it makes sense here.Changes