feat(completion): quote labels when necessary #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duologic
requested review from
julienduchesne,
jdbaldry and
zzehring
as code owners
Duologic
force-pushed
the
duologic/quote_labels
branch
from
68e3e1c to
779ab8d
Compare
Duologic
commented
Mar 8, 2024
Duologic
commented
Mar 11, 2024
Comment on lines
+220
to
+258
| // Start - Copied from go-jsonnet/internal/parser/lexer.go | ||
|
|
||
| func isUpper(r rune) bool { | ||
| return r >= 'A' && r <= 'Z' | ||
| } | ||
| func isLower(r rune) bool { | ||
| return r >= 'a' && r <= 'z' | ||
| } | ||
| func isNumber(r rune) bool { | ||
| return r >= '0' && r <= '9' | ||
| } | ||
| func isIdentifierFirst(r rune) bool { | ||
| return isUpper(r) || isLower(r) || r == '_' | ||
| } | ||
| func isIdentifier(r rune) bool { | ||
| return isIdentifierFirst(r) || isNumber(r) | ||
| } | ||
| func IsValidIdentifier(str string) bool { | ||
| if len(str) == 0 { | ||
| return false | ||
| } | ||
| for i, r := range str { | ||
| if i == 0 { | ||
| if !isIdentifierFirst(r) { | ||
| return false | ||
| } | ||
| } else { | ||
| if !isIdentifier(r) { | ||
| return false | ||
| } | ||
| } | ||
| } | ||
| // Ignore tokens for now, we should ask upstream to make the formatter a public package | ||
| // so we can use go-jsonnet/internal/formatter/pretty_field_names.go directly. | ||
| // return getTokenKindFromID(str) == tokenIdentifier | ||
| return true | ||
| } | ||
|
|
||
| // End - Copied from go-jsonnet/internal/parser/lexer.go |
There was a problem hiding this comment.
I've made a copy from upstream code as the formatter that has this logic is in an internal/ package. We should probably ask to make the formatter a public package.
There was a problem hiding this comment.
Ignoring the tokens because that would be too much to copy and maintain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When labels contain non-alpha characters or start with a number, they need to be quoted. This PR implements that for autocompletion.