refactor: always use TextEdit

grafana · Mar 11, 2024 · dead763 · dead763
1 parent 93cd2e2
commit dead763
Show file tree

Hide file tree

Showing 2 changed files with 315 additions and 8 deletions.
diff --git a/pkg/server/completion.go b/pkg/server/completion.go
@@ -197,18 +197,15 @@ func createCompletionItem(label, prefix string, kind protocol.CompletionItemKind
 	}
 	detail := prefix + concat + insertText
 
-	item := protocol.CompletionItem{
+	return protocol.CompletionItem{
 		Label:  label,
 		Detail: detail,
 		Kind:   kind,
 		LabelDetails: protocol.CompletionItemLabelDetails{
 			Description: typeToString(body),
 		},
 		InsertText: insertText,
-	}
-
-	if strings.HasPrefix(insertText, "[") {
-		item.TextEdit = &protocol.TextEdit{
+		TextEdit: &protocol.TextEdit{
 			Range: protocol.Range{
 				Start: protocol.Position{
 					Line:      position.Line,
@@ -220,10 +217,8 @@ func createCompletionItem(label, prefix string, kind protocol.CompletionItemKind
 				},
 			},
 			NewText: insertText,
-		}
+		},
 	}
-
-	return item
 }
 
 func typeToString(t ast.Node) string {