iterating on the underlying problem...

grafana · Jul 1, 2024 · dd41756 · dd41756
1 parent 1d117f1
commit dd41756
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/pkg/ast/processing/find_field.go b/pkg/ast/processing/find_field.go
@@ -74,6 +74,9 @@ func FindRangesFromIndexList(stack *nodestack.NodeStack, indexList []string, vm
 			if funcBody := findChildDesugaredObject(bodyNode.Body); funcBody != nil {
 				foundDesugaredObjects = append(foundDesugaredObjects, funcBody)
 			}
+		case *ast.Binary:
+			tmpStack := nodestack.NewNodeStack(bodyNode)
+			foundDesugaredObjects = FindTopLevelObjects(tmpStack, vm)
 		case *ast.Var:
 			varReference, err := FindVarReference(bodyNode, vm)
 			if err != nil {

diff --git a/pkg/server/completion_test.go b/pkg/server/completion_test.go
@@ -700,6 +700,15 @@ func TestCompletion(t *testing.T) {
 							Description: "object",
 						},
 					},
+					{
+						Label:      "step",
+						Kind:       protocol.FieldCompletion,
+						Detail:     "newjob.step",
+						InsertText: "step",
+						LabelDetails: protocol.CompletionItemLabelDetails{
+							Description: "object",
+						},
+					},
 				},
 			},
 		},

diff --git a/pkg/server/testdata/local_reassign.jsonnet b/pkg/server/testdata/local_reassign.jsonnet
@@ -2,7 +2,10 @@ local job = {
   steps: { name: 'a', value: 'b' },
 };
 
-local newjob = job;
+local newjob = job + {
+  steps: {},
+  step: super.steps,
+};
 
 {
   a: newjob,