[tempo] Add commonLabels (#3319) #3378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fabio trigari <[email protected]>
ftrigari
requested review from
Whyeasy,
dgzlopes,
Sheikh-Abubaker,
mapno,
swartz-k,
BitProcessor and
faustodavid
as code owners
|
@ramon951 Please open separate PR's for different charts, you can only make changes to one single chart in one PR otherwise the CI checks won't pass. |
|
Thank @Sheikh-Abubaker, I closed this PR in favor of the follow 3 PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every object created by the chart can have custom labels.
Fixes #3319
I edited 3 Tempo Charts using the same logic used for Mimir chart
I didn't edit dependency charts; I'm waiting for a feedback on how to proceed grafana/mimir#9067 (comment)