Chore: Fix prettier issues in test files #1710
Conversation
zoltanbedi
requested review from
gabor and
gwdawson
and removed request for
a team
|
I confirm 54612e6 fixes the issue. Thanks @zoltanbedi! |
|
Thanks @Antiz96. Is this blocking you right now? |
|
@zoltanbedi Well, I'm at least waiting for this PR to be reviewed/merged (just by conscience) to package the new version on Arch Linux repo. |
src/datasource/specs/utils.spec.ts
Outdated
| // Backward compatibility | ||
| it('should properly split query in old format', (done) => { | ||
| let test_cases = [ | ||
| { | ||
| query: `/alu/./tw-(nyc|que|brx|dwt|brk)-sta_(\w|\d)*-alu-[0-9{2}/`, | ||
| expected: ['/alu/', '/tw-(nyc|que|brx|dwt|brk)-sta_(\w|\d)*-alu-[0-9{2}/'] | ||
| expected: ['/alu/', '/tw-(nyc|que|brx|dwt|brk)-sta_(w|d)*-alu-[0-9{2}/'], |
There was a problem hiding this comment.
\w\d got turned into wd. i think this is a correct prettier-transform, but the original text looks very regex-ish... maybe the "before" situation was already wrong?
There was a problem hiding this comment.
you are right the query to escape w properly needs double backslash.
|
@Antiz96 if you are not blocked then we won't cut a release for code formatting. We will do that once we have other things to release as well. |
|
@zoltanbedi Sure, sounds good to me. I'll just backport the fixing commit once this PR is merged :) |
Fixes #1709