Add auto-approve and auto merge into automatic update action

[Ukochka]

Add ability to auto approve PR created by grafana-plugin bot to be able to automerge

[andresmgot]

shouldn't this be token: ${{ steps.generate_token.outputs.token }} as above?

[Ukochka]

no, it should not. Because if we are using the same token it thinks that it approves PR from itself. And it is not possible

[jackw]

I'm probably missing something but how does this auto merge the PR?

[tolzhabayev]

I think you can skip the auto approve completely, as it doesn't make much of a difference.

The bot user has the power to skip approvals and just merge it directly once the checks are green.

You would probably need something like https://github.com/re-actors/alls-green to ensure checks are actually green before merging.

A couple of examples on how to do it: https://jhale.dev/posts/auto-merging-prs/

[Ukochka]

@jackw Auto-merge option is already in github and it is enabled for this repo. When all the requirements are there - it will be automatically merged. I thought we need only approval, but I see that we actually need something else instead. @tolzhabayev shared the example

[tolzhabayev]

I think auto merge is not actually auto merge but an option you have to click on while the CI pipeline is running so that it will be merged once its done. But if you do not "click the button" it will not actually merge anything - e.g. this PR is not automatically merged although approved and all checks are green.

[Ukochka]

@tolzhabayev yeah, that's why I was thinking auto-approve will help, but seems like no and we need to use auto-merge action to do so

[jackw]

@Ukochka It seems we already have an action here that other repos are using to achieve this auto approve n merge of dependabot PRs?

[CLAassistant]

All committers have signed the CLA.

[Ukochka]

@tolzhabayev @jackw Hey guys, I have added merge part to this github actions. And I left approval part just to be sure. I think all-green is not needed here, because auto-merge anyway checks if everything is passed as I understand

[mckn]

Great work on this! Looks good 🙌🏻

With that said I'm not sure I think this feature is a good idea. Isn't it enough magic to get an PR with a updated create-plugin repository. If I would have this running in my repository I would disable this feature because I would like to be in control of when things like this gets merged.

[jackw]

@mckn I'm under the impression this action is intended only for the examples repo and isn't for plugin developers to use in their repos.

[tolzhabayev]

Alright let's see this in action

[jackw]

LGTM! 🚀

[tolzhabayev]

@Ukochka fixed the CLA check #364 (comment)