E2e tests for apps examples #321
Conversation
Ukochka
requested review from
marefr,
andresmgot and
oshirohugo
and removed request for
a team
Ukochka
force-pushed
the
e2e-tests-for-apps-examples
branch
from
77885c3
to
9b1513d
Compare
There was a problem hiding this comment.
Added some minor comments. Also please remove this file: examples/app-with-service-account/tests/auth.setup.js
For the scenes example app, I think we could do more specific tests. I have not yet explored how plugin-e2e can be tailored to better meet the need for scenes apps. If you want to, you can take a look at this. If now is not a good time for that, I'm fine just creating an issue for that so we can come back to this later on. Then we'll merge the scenes app tests as is.
examples/app-with-rbac/tests/viewer/appAuthenticationViewer.spec.ts
Outdated
Show resolved
Hide resolved
examples/app-with-rbac/tests/viewer/appAuthenticationViewer.spec.ts
Outdated
Show resolved
Hide resolved
examples/app-with-rbac/tests/viewer/appAuthenticationViewer.spec.ts
Outdated
Show resolved
Hide resolved
|
Also remember not to merge this before this pr is merged and released. |
|
@Ukochka when updating plugin-e2e, can you please bump all example plugins when you're at it? Also saw that a bunch of example plugin uses a pinned version of plugin-e2e. Can you change that to use the |
|
@sunker I've fixed all the comment, please have a look. |
e2e tests for:
app-with-rbac
app-with-service-account
app-with-scenes