Update node version to 18 #202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oshirohugo can you please change this to node 20 (context) BUT probably you would have to also bump some of the dependencies that will break by doing so - so please test locally with node 20 and make sure the integration tests are passing. |
|
closing this in favor of #213 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates node version to 18
Closes #199
Note for reviewer
I've checked all the js files build using node 16 and compare it with the ones created by node 18. And everything was exactly the same.
I've used this script https://gist.github.com/oshirohugo/2f1a7de9f25487a74c4f3d939025722d
The integration tests in github are also passing (except datasource-basic) that will be fixed soon and it's related to an update in grafana grafana/grafana#74795