-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples: Add log data source #200
Conversation
Just wanted to check on this - if you've had time to review/have any feedback 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!! Sorry if this took so long 😞
I took it up for a spin and it works really well 👏 👏
Looks great so far! I only have a few comments:
It would also be great to see how it would look like combined with a backend component, rather than frontend-only, but that's something that we look into later on.
@xnyo the integration test is failing on |
Okay, I was able to figure it out. Seems like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
It looks like this has been bumped to |
Based on conversation with @xnyo I am creating a PR that adds a new datasource example with datasource that implements logging features. The datasource just mocks receiving of logs trough
mockDataRequest.ts
. Let me know if there is anything I need to change/update. 🙂