Add qdrant read vector store implementation #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sd2k
force-pushed
the
vector-service-qdrant
branch
2 times, most recently
from
a68c495
to
3805348
Compare
sd2k
force-pushed
the
vector-service-qdrant
branch
from
3805348
to
8556969
Compare
PR #33 can't really be merged until we open-source and package up vectorapi, so this commit adds a qdrant implementation and modifies the provisioning file to use it (and OpenAI) by default, rather than vectorapi.
sd2k
force-pushed
the
vector-service-qdrant
branch
from
8556969
to
fa30317
Compare
csmarchbanks
approved these changes
Sep 12, 2023
Otherwise the payloads are JSON marshaled like this:
```json
{"results":[{"payload":{"description":{"Kind":{"NullValue":0}},"panels":{"Kind":{"ListValue":{"values":[{"Kind":{"StructValue":{"fields":{"description":{"Kind":{"StringValue":"CPU usage of Mimir"}},"title":{"Kind":{"StringValue":"CPU usage"}}}}}}]}}},"title":{"Kind":{"StringValue":"Mimir resource usage"}}},"score":0.7932371497154236}]}
```
instead of what we want (after this PR):
```json
{"results":[{"payload":{"description":null,"panels":[{"description":"CPU usage of Mimir","title":"CPU usage"}],"title":"Mimir resource usage"},"score":0.7932371497154236}]}
```
|
I noticed an issue with the payload marshalling due to the payload being stored in a bunch of nested gRPC structs. Should be fixed by cba49f6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #33 can't really be merged until we open-source and package up vectorapi, so this commit adds a qdrant implementation and modifies the provisioning file to use it (and OpenAI) by default, rather than vectorapi.
Still a little hard to test without any way of synchronising data in there, I've been working on https://github.com/grafana/grafana-llm-app/compare/vector-service-qdrant...vector-sync-2?expand=1 to make it a bit easier to get data in and test it but it's not really ideal.