Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages: Hide package types that are throwing error #366

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

ivanahuckova
Copy link
Member

This PR removes following package types from the dropdown, as they all throw XXX registry is not supported by GraphQL APIs. In a case where user had previously selected one of the package types and have it saved in a query, we are going to keep it available.
image
image
image

Manual test:

  1. It shows that leftover package types are not throwing errors
  2. It shows that if user had NPM (or other) package ty[e selected before, it will be still available in the dropdown
npm.mov

@ivanahuckova ivanahuckova requested a review from a team as a code owner September 23, 2024 15:16
@ivanahuckova ivanahuckova changed the title Packages: Hide package types that were throwing error Packages: Hide package types that are throwing error Sep 23, 2024
Copy link
Member

@gwdawson gwdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivanahuckova ivanahuckova merged commit f34daa9 into main Sep 26, 2024
10 checks passed
@ivanahuckova ivanahuckova deleted the hide-packagetype-options branch September 26, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants