Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gcs): Create unit tests + benchmarks #42

Merged
merged 1 commit into from
Dec 8, 2023
Merged

feat(gcs): Create unit tests + benchmarks #42

merged 1 commit into from
Dec 8, 2023

Commits on Dec 8, 2023

  1. feat(gcs): Create unit tests + benchmarks 

    Introduces unit tests and benchmarks for the bucket_cache.go file.
It was raised during implementation that using `defer` has a performance penalty, but I wanted to use benchmarks to measure it.
By removing defers, we end up with roughly 5% performance gains.
In practice though, this should be minor and have neglibable impact on overall performance.
    @Pokom
    Pokom committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    785475a View commit details
    Browse the repository at this point in the history