fix(gke): Update collect method to gracefully fail #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a condition where a failure to find a machine type in the price map was causing the `Collect` method to return instead of continuing. Instead, this changes the logic to log out the message within `Collect` and continue operating. Adds a unit test to reproduce the error and then validates it is resolved. A future improvement here would be to 1. Export a metric 2. Set a sane default value(if provided?) - closes #335
Pokom
commented
Oct 22, 2024
Comment on lines
+217
to
+225
| c.logger.LogAttrs(ctx, | ||
| slog.LevelError, | ||
| err.Error(), | ||
| slog.String("disk_name", disk.Name), | ||
| slog.String("project", project), | ||
| slog.String("region", d.Region()), | ||
| slog.String("cluster_name", d.Cluster), | ||
| slog.String("storage_class", d.StorageClass()), | ||
| ) |
There was a problem hiding this comment.
This wasn't part of the issue linked in the PR, but it's good cleanup to convert the section to using slog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a condition where a failure to find a machine type in the price map was causing the
Collectmethod to return instead of continuing. Instead, this changes the logic to log out the message withinCollectand continue operating.Adds a unit test to reproduce the error and then validates it is resolved.
A future improvement here would be to