refactor(GCS): Migrate to using mockery/testify #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is my first attempt at using the [mockery](https://vektra.github.io/mockery/latest/) library to generate mocks. Previously we crafted our own mocks by hand for the GCS StorageClientInterface and hand wrote our own interceptors. I generated the mocked interfaces by running `mockery` locally. In order for `mockery` to recognize files, I had to create a `main.go` file in the root of the project. This newer way of running `mockery` requires you to generate mocks for _all_ interfaces. I updated the tests for buckets to use the new mocked interface. On Monday my plan is to extend the mocks and use testify to alter the behavior so I can do things like handle errors, and all of that fun stuff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first attempt at using the mockery library to generate mocks. Previously we crafted our own mocks by hand for the GCS StorageClientInterface and hand wrote our own interceptors. I generated the mocked interfaces by running
mockerylocally. In order formockeryto recognize files, I had to create amain.gofile in the root of the project. This newer way of runningmockeryrequires you to generate mocks for all interfaces.I updated the tests for buckets to use the new mocked interface. On Monday my plan is to extend the mocks and use testify to alter the behavior so I can do things like handle errors, and all of that fun stuff.