Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Temporary Credentials #284

Merged
merged 6 commits into from
Oct 17, 2023
Merged

Conversation

sarahzinger
Copy link
Member

@sarahzinger sarahzinger commented Oct 5, 2023

Adds support for our new Temporary Credentials Feature, currently in Private Preview in Grafana Cloud.

Fixes https://github.com/grafana/oss-plugin-partnerships/issues/259

Adds:

  • new resource route: /externalId which fetches external id from the env and returns it if there
  • hits that new route whenever we load the Config Editor and the selected auth provider is Grafana Assume Role

To Test locally:

[aws]
allowed_auth_providers = keys,grafana_assume_role
assume_role_enabled = true
external_id = '12345678'

[feature_toggles]
awsDatasourcesTempCredentials = true
  • and in .aws/credentials add an access/secret key of a user that has the ability to assume a role

I think it might be easiest to

Copy link
Contributor

@kevinwcyu kevinwcyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@maczikasz
Copy link

Hi, do I understand right that using the Assume ASW role feature of grafana cloud would only work with the Athena plugin after this PR is merged

Do you have an ETA on this?

Thanks

@sarahzinger sarahzinger merged commit c3481b2 into main Oct 17, 2023
4 checks passed
@sarahzinger sarahzinger deleted the sarahzinger/temp-credentials branch October 17, 2023 12:30
@sarahzinger
Copy link
Member Author

@maczikasz If you want Grafana to assume an IAM role on your behalf in Grafana Cloud to use the Athena Datasource yes this pr makes that possible! It should be available in version 2.12.0 of the athena plugin (will be out later today)

Right now this feature is in Private Preview and under a feature toggle but if you open up a support ticket we will be more than happy to enable it on your account to grant you early access! We recently added some documentation on this here grafana/grafana#75178 (most of it is directed towards cloudwatch but the logic should be the same)

@maczikasz
Copy link

@sarahzinger amazing, thank you for the fast response. I have the feature in grafana cloud enabled already, so will try as soon as the new version is released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants