-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Temporary Credentials #284
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
06a49fe
to
1d70ca4
Compare
Hi, do I understand right that using the Assume ASW role feature of grafana cloud would only work with the Athena plugin after this PR is merged Do you have an ETA on this? Thanks |
@maczikasz If you want Grafana to assume an IAM role on your behalf in Grafana Cloud to use the Athena Datasource yes this pr makes that possible! It should be available in version 2.12.0 of the athena plugin (will be out later today) Right now this feature is in Private Preview and under a feature toggle but if you open up a support ticket we will be more than happy to enable it on your account to grant you early access! We recently added some documentation on this here grafana/grafana#75178 (most of it is directed towards cloudwatch but the logic should be the same) |
@sarahzinger amazing, thank you for the fast response. I have the feature in grafana cloud enabled already, so will try as soon as the new version is released |
Adds support for our new Temporary Credentials Feature, currently in Private Preview in Grafana Cloud.
Fixes https://github.com/grafana/oss-plugin-partnerships/issues/259
Adds:
/externalId
which fetches external id from the env and returns it if thereGrafana Assume Role
To Test locally:
I think it might be easiest to