Support Node 18 #276
Merged
Support Node 18 #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinwcyu
force-pushed
the
kevinwcyu/node-18
branch
5 times, most recently
from
1879bd3
to
41184ba
Compare
kevinwcyu
force-pushed
the
kevinwcyu/node-18
branch
3 times, most recently
from
990f087
to
5cdd778
Compare
kevinwcyu
commented
Oct 18, 2023
|
|
||
| e2e.flows.addPanel({ | ||
| visitDashboardAtStart: false, | ||
| dataSourceName, | ||
| queriesForm: () => { | ||
| // Change database selection for query | ||
| e2eSelectors.ConfigEditor.database.input().click({ force: true }); | ||
| e2e().contains('cloudtrail'); | ||
| // TODO fix the ResourceSelector to load the list of databases when clicked |
There was a problem hiding this comment.
Created issue #291
kevinwcyu
force-pushed
the
kevinwcyu/node-18
branch
from
5cdd778
to
5f77f5e
Compare
sarahzinger
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rm -rf node_modules && yarn && yarn lint && yarn test:ci && yarn buildthen tested it with a simple query