Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add otelcol.receiver.file_stats component #812

Merged
merged 7 commits into from
May 9, 2024

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented May 9, 2024

PR Description

Add an otelcol.receiver.file_stats component which wraps around the upstream filestatsreceiver component from the -contrib distribution.

Which issue(s) this PR fixes

Closes #238.

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@rfratto rfratto added backport-to-agent:no PR should NOT be backported to the agent repo. backport release/v1.1 labels May 9, 2024
Add an otelcol.receiver.file_stats component which wraps around the
upstream filestatsreceiver component from the -contrib distribution.

Closes grafana#238.
@rfratto rfratto marked this pull request as ready for review May 9, 2024 17:10
@rfratto rfratto requested a review from mattdurham May 9, 2024 17:41
A bug in the upstream receiver prevents the component from compiling
properly on FreeBSD. As a temporary workaround, we shim out
implementations on unsupported platforms and return a fake component
which is always unhealthy.
Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I hate that the config is internal and we have to use creative ways around it.

@rfratto rfratto enabled auto-merge (squash) May 9, 2024 18:32
@rfratto rfratto merged commit 006339c into grafana:main May 9, 2024
15 checks passed
github-actions bot pushed a commit that referenced this pull request May 9, 2024
Add an otelcol.receiver.file_stats component which wraps around the
upstream filestatsreceiver component from the -contrib distribution.

Because of an upstream bug, this component does not currently work
on FreeBSD.

Closes #238.

(cherry picked from commit 006339c)
@rfratto rfratto deleted the filestatsreceiver branch May 9, 2024 18:34
rfratto added a commit that referenced this pull request May 9, 2024
Add an otelcol.receiver.file_stats component which wraps around the
upstream filestatsreceiver component from the -contrib distribution.

Because of an upstream bug, this component does not currently work
on FreeBSD.

Closes #238.

(cherry picked from commit 006339c)

Co-authored-by: Robert Fratto <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport release/v1.1 backport-to-agent:no PR should NOT be backported to the agent repo. frozen-due-to-age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flow: add otelcol.receiver.file_stats
2 participants