-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add otelcol.receiver.file_stats component #812
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
added
backport-to-agent:no
PR should NOT be backported to the agent repo.
backport release/v1.1
labels
May 9, 2024
Add an otelcol.receiver.file_stats component which wraps around the upstream filestatsreceiver component from the -contrib distribution. Closes grafana#238.
mattdurham
reviewed
May 9, 2024
docs/sources/reference/components/otelcol.receiver.file_stats.md
Outdated
Show resolved
Hide resolved
mattdurham
reviewed
May 9, 2024
docs/sources/reference/components/otelcol.receiver.file_stats.md
Outdated
Show resolved
Hide resolved
A bug in the upstream receiver prevents the component from compiling properly on FreeBSD. As a temporary workaround, we shim out implementations on unsupported platforms and return a fake component which is always unhealthy.
mattdurham
approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I hate that the config is internal and we have to use creative ways around it.
rfratto
added a commit
that referenced
this pull request
May 9, 2024
Add an otelcol.receiver.file_stats component which wraps around the upstream filestatsreceiver component from the -contrib distribution. Because of an upstream bug, this component does not currently work on FreeBSD. Closes #238. (cherry picked from commit 006339c) Co-authored-by: Robert Fratto <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport release/v1.1
backport-to-agent:no
PR should NOT be backported to the agent repo.
frozen-due-to-age
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add an otelcol.receiver.file_stats component which wraps around the upstream filestatsreceiver component from the -contrib distribution.
Which issue(s) this PR fixes
Closes #238.
Notes to the Reviewer
PR Checklist