(Experiment) Dockerfile.windows: remove clean cache step #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR grafana/agent#6671 split out cleaning the Go cache into its own step. This increased build times as stages are slow to produce on Windows. As Dockerfile.windows is a multi-stage Dockerfile, and the cache doesn't carry over to the final image, cleaning the Go cache can be safely skipped to reduce the overall build time.
|
The theory was wrong here, and it in fact takes longer than before. I'm not quite sure why this is (maybe something to do with the final size of the intermediate container stage), but in any case this isn't measurably improving anything so I'll close. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR grafana/agent#6671 split out cleaning the Go cache into its own step. This increased build times as stages are slow to produce on Windows.
As Dockerfile.windows is a multi-stage Dockerfile, and the cache doesn't carry over to the final image, cleaning the Go cache can be safely skipped to reduce the overall build time.