Update loki.source.api.md #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The /loki/ready endpoint does not seem to be a valid one. Instead should be /ready as stated here: https://github.com/grafana/alloy/blob/main/internal/component/loki/source/api/internal/lokipush/push_api_server.go#L78 and here https://grafana.com/docs/loki/latest/reference/api/#status-endpoints
|
|
clayton-cornell
added
type/docs
clayton-cornell
approved these changes
Apr 16, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
The /loki/ready endpoint does not seem to be a valid one. Instead should be /ready as stated here: https://github.com/grafana/alloy/blob/main/internal/component/loki/source/api/internal/lokipush/push_api_server.go#L78 and here https://grafana.com/docs/loki/latest/reference/api/#status-endpoints (cherry picked from commit 217fbd9)
clayton-cornell
pushed a commit
that referenced
this pull request
Apr 16, 2024
The /loki/ready endpoint does not seem to be a valid one. Instead should be /ready as stated here: https://github.com/grafana/alloy/blob/main/internal/component/loki/source/api/internal/lokipush/push_api_server.go#L78 and here https://grafana.com/docs/loki/latest/reference/api/#status-endpoints (cherry picked from commit 217fbd9) Co-authored-by: marybelvargas <[email protected]>
hainenber
pushed a commit
to hainenber/alloy
that referenced
this pull request
May 1, 2024
The /loki/ready endpoint does not seem to be a valid one. Instead should be /ready as stated here: https://github.com/grafana/alloy/blob/main/internal/component/loki/source/api/internal/lokipush/push_api_server.go#L78 and here https://grafana.com/docs/loki/latest/reference/api/#status-endpoints
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
/loki/readyendpoint does not seem to be a valid one. Instead should be/readyas stated here: https://github.com/grafana/alloy/blob/main/internal/component/loki/source/api/internal/lokipush/push_api_server.go#L78 and here https://grafana.com/docs/loki/latest/reference/api/#status-endpointsPR Description
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist