-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about collecting from Kubernetes Pods #1972
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -163,17 +158,15 @@ Clustering only looks at the following labels for determining the shard key: | |||
|
|||
## Exported fields | |||
|
|||
`loki.source.kubernetes` does not export any fields. | |||
`loki.source.kubernetes` doesn't export any fields. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit surprised we prefer contractions!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We generally follow the Google Developer's style guide (with a few modifications as documented in the Writer's Toolkit). Contractions are preferred as outlined here: https://developers.google.com/style/contractions
Quoting the guideline: "In general, we write our documentation in an informal tone, so we recommend using most types of contractions."
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-1972-to-release/v1.0 origin/release/v1.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x b558c01237c16536f46e8cdafdebde9156da158b
# Push it to GitHub
git push --set-upstream origin backport-1972-to-release/v1.0
git switch main
# Remove the local backport branch
git branch -D backport-1972-to-release/v1.0 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-1972-to-release/v1.1 origin/release/v1.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x b558c01237c16536f46e8cdafdebde9156da158b
# Push it to GitHub
git push --set-upstream origin backport-1972-to-release/v1.1
git switch main
# Remove the local backport branch
git branch -D backport-1972-to-release/v1.1 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-1972-to-release/v1.2 origin/release/v1.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x b558c01237c16536f46e8cdafdebde9156da158b
# Push it to GitHub
git push --set-upstream origin backport-1972-to-release/v1.2
git switch main
# Remove the local backport branch
git branch -D backport-1972-to-release/v1.2 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-1972-to-release/v1.3 origin/release/v1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x b558c01237c16536f46e8cdafdebde9156da158b
# Push it to GitHub
git push --set-upstream origin backport-1972-to-release/v1.3
git switch main
# Remove the local backport branch
git branch -D backport-1972-to-release/v1.3 Then, create a pull request where the |
(cherry picked from commit b558c01)
(cherry picked from commit b558c01)
(cherry picked from commit b558c01)
(cherry picked from commit b558c01)
(cherry picked from commit b558c01)
PR Description
In this PR:
Which issue(s) this PR fixes
#431
Notes to the Reviewer
PR Checklist