Add benchmarks for loki.secretfilter component #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romain-gaillard
commented
Oct 15, 2024
| @@ -270,7 +270,7 @@ func (c *Component) Update(args component.Arguments) error { | |||
| // Compile regexes | |||
| for _, rule := range gitleaksCfg.Rules { | |||
| // If specific secret types are provided, only include rules that match the types | |||
| if c.args.Types != nil && len(c.args.Types) > 0 { | |||
There was a problem hiding this comment.
Just fixing a warning by the linter that said the nil check was redundant.
wildum
approved these changes
Oct 15, 2024
pbailhache
pushed a commit
to pbailhache/alloy
that referenced
this pull request
Oct 17, 2024
* Add benchmarks * More benchmarks * Don't fail tests if the temp file can't be deleted * Don't fail tests if the temp file can't be deleted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds benchmarks for the
loki.secretfiltercomponent.Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist