-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pyroscope.receive_http
component for profile handling
#1886
feat: add pyroscope.receive_http
component for profile handling
#1886
Conversation
9ff53cf
to
8181a7f
Compare
8181a7f
to
ffa4dbd
Compare
docs/sources/reference/components/pyroscope/pyroscope.receive_http.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/pyroscope/pyroscope.receive_http.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/pyroscope/pyroscope.receive_http.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/pyroscope/pyroscope.receive_http.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/pyroscope/pyroscope.receive_http.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/pyroscope/pyroscope.receive_http.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/pyroscope/pyroscope.receive_http.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Clayton Cornell <[email protected]>
5faaeab
to
f536f23
Compare
Let's wait for review from a Pyroscope team member as well before merging 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one nit regarding reading the whole profile in memory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, great job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, will wait for clayton to review before approving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK.
PR Description
This PR introduces the new
pyroscope.receive_http
component, which allows for receiving and forwarding Pyroscope profiles. Key features and changes include:/ingest
endpointpyroscope.write
componentsWhich issue(s) this PR fixes
Relates to #270
Notes to the Reviewer
PR Checklist