-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add hostAliases to helm chart #1662
Conversation
This PR has not had any activity in the past 30 days, so the |
@petewall another helm chart PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me
@duncan485 thanks for contributing and sorry for looking at the PR so late. There is a lint issue, would you mind rebasing your branch with main and running |
Hey @wildum . Thanks! No problem, took me a while to get back to this as well. I rebased it and rerun the |
hey @wildum I see there is still a test failing, is there anything I can do about it ? I'm not sure it's related to the Chart. |
Hey sorry about that, this seems to be a flaky test from an experimental WAL feature that we are testing. As long as the tests run in drone then we are fine, it's not a blocker for this PR |
Merged! Thanks again for the contribution! |
Add hostAliases to alloy pod
Notes to the Reviewer
I'd like to be able to add hostAliases to the pod. Any feedback is welcome
PR Checklist