packaging: properly unregister Alloy when uninstalling on Windows #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grafana/agent#6550 fixed an issue where the service settings were not being removed properly, but inadvertedly broke the process of removing the application from the Add/Remove programs list. Alloy is registered as a program to the 32-bit registry, and so it must be removed from the 32-bit registry and not the 64-bit registry. Fixes #165. As a temporary workaround to this bug, users should delete HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Alloy from the 32-bit registry.
|
This makes sense but its super painful we have to use both registries. |
tpaschalis
approved these changes
Apr 17, 2024
rfratto
added
the
backport-to-agent:done
hainenber
pushed a commit
to hainenber/alloy
that referenced
this pull request
May 1, 2024
…afana#166) grafana/agent#6550 fixed an issue where the service settings were not being removed properly, but inadvertedly broke the process of removing the application from the Add/Remove programs list. Alloy is registered as a program to the 32-bit registry, and so it must be removed from the 32-bit registry and not the 64-bit registry. Fixes grafana#165. As a temporary workaround to this bug, users should delete HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Alloy from the 32-bit registry. Co-authored-by: Paschalis Tsilias <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grafana/agent#6550 fixed an issue where the service settings were not being removed properly, but inadvertedly broke the process of removing the application from the Add/Remove programs list.
Alloy is registered as a program to the 32-bit registry, and so it must be removed from the 32-bit registry and not the 64-bit registry.
Fixes #165.
As a temporary workaround to this bug, users should delete HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Alloy from the 32-bit registry.