Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update automatically settting gomemlimit #1188

Merged
merged 14 commits into from
Oct 30, 2024
Merged

update automatically settting gomemlimit #1188

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
bf66594
update automatically settting gomemlimit
mattdurham Jul 3, 2024
0fb2507
update doc
mattdurham Jul 3, 2024
919cb3a
Update changelog for v1.2.1.
mattdurham Jul 11, 2024
b625791
Merge branch 'main' of github.com:grafana/alloy
mattdurham Jul 11, 2024
295713d
Merge branch 'main' of github.com:grafana/alloy
mattdurham Jul 11, 2024
8749cbe
Merge branch 'main' of github.com:grafana/alloy
mattdurham Jul 15, 2024
fb7d364
merge main
mattdurham Jul 15, 2024
52af0a2
Update docs
mattdurham Jul 15, 2024
62bd98f
Update docs/sources/reference/cli/environment-variables.md
mattdurham Jul 16, 2024
fc9ea6e
Update docs/sources/reference/cli/environment-variables.md
mattdurham Jul 16, 2024
cf0a568
Update docs/sources/reference/cli/environment-variables.md
mattdurham Jul 18, 2024
9d808e4
Update docs/sources/reference/cli/environment-variables.md
mattdurham Jul 18, 2024
5757575
merge main
mattdurham Oct 17, 2024
215f3b3
fix typo
mattdurham Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,15 @@ Main (unreleased)
### Enhancements

- Added a success rate panel on the Prometheus Components dashboard. (@thampiotr)

- Add namespace field to Faro payload (@cedricziel)

- Graduate automatically setting GOMEMLIMIT to Generally Available from Public Preview. (@mattdurham)

### Bugfixes

- Fixed an issue with `loki.source.kubernetes_events` not starting in large clusters due to short informer sync timeout. (@nrwiersma)

- Updated [ckit](https://github.com/grafana/ckit) to fix an issue with armv7 panic on startup when forming a cluster. (@imavroukakis)

v1.2.0
Expand Down
4 changes: 1 addition & 3 deletions internal/alloycli/cmd_run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,9 +197,7 @@ func (fr *alloyRun) Run(configPath string) error {

// Set the memory limit, this will honor GOMEMLIMIT if set
// If there is a cgroup will follow that
if fr.minStability.Permits(featuregate.StabilityPublicPreview) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to remove the Permits function? 😂
It could be useful though, just that I don't think it's used now so YAGNI.

memlimit.SetGoMemLimitWithOpts(memlimit.WithLogger(slog.New(l.Handler())))
}
memlimit.SetGoMemLimitWithOpts(memlimit.WithLogger(slog.New(l.Handler())))

// Enable the profiling.
setMutexBlockProfiling(l)
Expand Down
Loading