-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update automatically settting gomemlimit #1188
Merged
+41
−26
Merged
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
bf66594
update automatically settting gomemlimit
mattdurham 0fb2507
update doc
mattdurham 919cb3a
Update changelog for v1.2.1.
mattdurham b625791
Merge branch 'main' of github.com:grafana/alloy
mattdurham 295713d
Merge branch 'main' of github.com:grafana/alloy
mattdurham 8749cbe
Merge branch 'main' of github.com:grafana/alloy
mattdurham fb7d364
merge main
mattdurham 52af0a2
Update docs
mattdurham 62bd98f
Update docs/sources/reference/cli/environment-variables.md
mattdurham fc9ea6e
Update docs/sources/reference/cli/environment-variables.md
mattdurham cf0a568
Update docs/sources/reference/cli/environment-variables.md
mattdurham 9d808e4
Update docs/sources/reference/cli/environment-variables.md
mattdurham 5757575
merge main
mattdurham 215f3b3
fix typo
mattdurham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -200,9 +200,7 @@ func (fr *alloyRun) Run(configPath string) error { | |
|
||
// Set the memory limit, this will honor GOMEMLIMIT if set | ||
// If there is a cgroup will follow that | ||
if fr.minStability.Permits(featuregate.StabilityPublicPreview) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Want to remove the |
||
memlimit.SetGoMemLimitWithOpts(memlimit.WithLogger(slog.New(l.Handler()))) | ||
} | ||
memlimit.SetGoMemLimitWithOpts(memlimit.WithLogger(slog.New(l.Handler()))) | ||
|
||
// Enable the profiling. | ||
setMutexBlockProfiling(l) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clayton-cornell I added some doc here but its rough, would love additional eyes.