Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up some broken links to Loki #7034

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Fix up some broken links to Loki #7034

merged 4 commits into from
Sep 25, 2024

Conversation

clayton-cornell
Copy link
Contributor

PR Description

This PR fixes some broken links that a community member found.

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@clayton-cornell clayton-cornell requested a review from a team September 23, 2024 16:39
jdbaldry
jdbaldry reviewed Sep 24, 2024
View reviewed changes
Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we've set LOKI_VERSION in the cascading front matter for Agent which will mean it will be substituted with the current Agent version, which Is probably not what you want

@clayton-cornell
Copy link
Contributor Author

I'm not sure we've set LOKI_VERSION in the cascading front matter for Agent which will mean it will be substituted with the current Agent version, which Is probably not what you want

Fixed up with links to latest. In this case, this should be fine.

@clayton-cornell clayton-cornell requested review from jdbaldry and a team September 24, 2024 16:59
@clayton-cornell clayton-cornell merged commit 93fb1c1 into main Sep 25, 2024
10 checks passed
@clayton-cornell clayton-cornell deleted the docs/fix-broken-links-to-loki branch September 25, 2024 22:09
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Oct 26, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wildum wildum wildum approved these changes

@jdbaldry jdbaldry Awaiting requested review from jdbaldry

Assignees
No one assigned
Labels
backport release-v0.41 backport release-v0.42 backport release-v0.43 frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clayton-cornell @jdbaldry @wildum