-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding make files from PR #78 #178
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize that you're just trying to get this stuff committed (and you didn't write any of this), but the descriptions in the headers of these files is erroneous.
I know you probably can't/don't have time for fixing it all up nicely. Maybe we should delete erroneous information? (I think it would be better for the descriptions to be incomplete rather than contain incorrect information -- it reduces the chance of confusion for new users)
@@ -0,0 +1,98 @@ | |||
#======================================================================= | |||
# | |||
# FILE: Make.mach.tacc-stampede-intel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# FILE: Make.mach.tacc-stampede-intel | |
# FILE: Make.mach.tacc-frontera-intel |
# DESCRIPTION: TACC Stampede Makefile | ||
# Written by Cameron Hummels, Jan 14 | ||
# Edited by Gabriel Altay, Sept 14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# DESCRIPTION: TACC Stampede Makefile | |
# Written by Cameron Hummels, Jan 14 | |
# Edited by Gabriel Altay, Sept 14 | |
# DESCRIPTION: TACC Frontera Makefile (descended from tacc-frontera file | |
# Written by Cameron Hummels, Jan 14 | |
# Edited by Gabriel Altay, Sept 14 | |
# Edited by Gen Chiaki |
@@ -0,0 +1,98 @@ | |||
#======================================================================= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file kind of duplicates Make.mach.tacc-stampede-intel
, right? So I'm not sure it makes sense to add this (especially since TACC is moving to stampede3)
@@ -0,0 +1,93 @@ | |||
#======================================================================= | |||
# | |||
# FILE: Make.mach.tacc-stampede-intel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# FILE: Make.mach.tacc-stampede-intel | |
# FILE: Make.mach.sdsc-comet |
# FILE: Make.mach.linux-gnu | ||
# | ||
# DESCRIPTION: Makefile settings for a machine running Ubuntu 8.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably needs updating
# FILE: Make.mach.linux-gnu | ||
# | ||
# DESCRIPTION: Makefile settings for a machine running Ubuntu 8.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably needs updating
# FILE: Make.mach.linux-gnu | ||
# | ||
# DESCRIPTION: Makefile settings for a machine running Ubuntu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably needs updating
# FILE: Make.mach.linux-gnu | ||
# | ||
# DESCRIPTION: Makefile settings for a machine running Ubuntu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably needs updating
# FILE: Make.mach.linux-gnu | ||
# | ||
# DESCRIPTION: Makefile settings for a machine running Ubuntu | ||
# | ||
# AUTHOR: Rick Wagner ([email protected]) | ||
# | ||
# DATE: 2008-09-16 | ||
# | ||
# This configuration assumes that build-essentials, gfortran, | ||
# OpenMPI and HDF5 have been installed using apt-get. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This definitely needs updating! (Probably more than any other Makefile, the header here is confusing. Presumably this works when using windows subsystem for linux?)
Yeah, I agree, we can fix them up, or minimally, remove information. It might even be worth going through them to see which ones are simple duplicates. I'll get to this eventually, but before we merge these. |
This adds the new make files that were included in PR #78 (#143, #177).