Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump macOS CI versions #1384

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

yuzawa-san
Copy link
Contributor

@yuzawa-san yuzawa-san commented Oct 16, 2024

per https://github.com/orgs/Homebrew/discussions/5603

macOS 12 is no longer supported by homebrew. it will run but the fast installation from "bottles" (precompiled blobs) will no longer work. this causes the dependencies to be compiled from source which takes a very long time, hence the timeouts.

for this reason i'm moving to the later versions which are still supported and have the fast bottles.

NOTE: the sdk baseline is not changing, so versions 12 and earlier should still work.

@yuzawa-san
Copy link
Contributor Author

@argilo I added your changes and also made some permissions fixes to address macOS 14 runner quirks https://github.com/orgs/Homebrew/discussions/5603

both the CI and Build workflows appear to have passed:

https://github.com/yuzawa-san/gqrx/actions/runs/11365851271
https://github.com/yuzawa-san/gqrx/actions/runs/11365851267

BUT: i was incorrect about that baseline changing. i'm going to put this into draft until i can dig into that further.

@yuzawa-san yuzawa-san marked this pull request as draft October 16, 2024 13:06
@argilo
Copy link
Member

argilo commented Oct 16, 2024

i was incorrect about that baseline changing.

I think it's unavoidable as long as the build uses packages from Homebrew.

@argilo
Copy link
Member

argilo commented Oct 16, 2024

I was holding off on updating to macOS 13 as long as I could to avoid increasing the baseline, but at this point there is no choice.

Perhaps getting packages from conda or building from source would solve the problem, but I don't know enough about building software on macOS to do that.

@argilo argilo marked this pull request as ready for review October 16, 2024 15:43
@argilo
Copy link
Member

argilo commented Oct 16, 2024

Thanks for the changes.

It looks like I accidentally checked in an unrelated change on the fix-win-build branch. I squashed commits here and remove that extraneous change. I'll merge once CI passes.

@argilo argilo merged commit 85d811a into gqrx-sdr:master Oct 16, 2024
17 checks passed
@yuzawa-san
Copy link
Contributor Author

i am going to continue to dig into the baseline.

i'll also take a look at ARM builds as well since I do have experience on mac builds.

@argilo
Copy link
Member

argilo commented Oct 16, 2024

Thanks.

It would be great to have a proper ARM build, as there is plenty of interest: #1104

I believe the macos-14 runner is ARM, so that could be used if needed.

Unfortunately I don't have any hardware myself to use for testing.

@argilo
Copy link
Member

argilo commented Oct 16, 2024

I pushed one more fix to get code signing working. (For some reason base64's --output argument was not working on macOS 13.) CI & builds should be working on the master branch now.

@argilo
Copy link
Member

argilo commented Oct 16, 2024

Perhaps getting packages from conda

By the way, Gqrx's Linux AppImage build is based on conda packages. It appears that conda packages target macOS 10.13+, so they may be a good choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants