fix: smoke test flakes #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perform some prompt engineering on the smoke test judge and test cases to make result comparison more reliable. This will stop the smoke tests from flaking. Signed-off-by: Nick Hale <[email protected]>
njhale
requested review from
drpebcak,
thedadams,
StrongMonkey,
g-linville and
tylerslaton
iwilltry42
approved these changes
Jun 21, 2024
tylerslaton
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perform some prompt engineering on the smoke test judge and test cases
to make result comparison more reliable. This will stop the smoke tests from
flaking.
Note: Reran this with
-count=10for each model locally and didn't get any flakes.