Do not download when licence is not set #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-gribanov
requested changes
Nov 18, 2024
peter-gribanov
changed the title
|
Thanks for the PR 👍 Please fix the unit tests. |
|
@peter-gribanov updated the tests and added a new test for a case without license |
peter-gribanov
approved these changes
Nov 19, 2024
|
Good job 👍 Thank you. |
|
@antedebaas your feature published in Release 2.1.2 |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed the bundle not fail in the command because a license has not been set
for my project there are use cases where a license will not be used (its up to the user)
this pr will instead of blindly try a download show a warning when the license is not set and skip the download step.