Incorporate https://github.com/grails/scaffolding-old code and docs into fields plugin #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tputProperties instead of listOutputProperties with embedded domains because they may not have an ID
sbglasius
approved these changes
Sep 24, 2024
codeconsole
approved these changes
Sep 24, 2024
jamesfredley
added a commit
to grails/grails-core
that referenced
this pull request
Sep 25, 2024
…directly into the fields plugin gpc/fields#364
jamesfredley
added a commit
to grails/grails-core
that referenced
this pull request
Sep 28, 2024
…directly into the fields plugin (#13688) gpc/fields#364
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fields is the only current plugin still using org.grails:scaffolding-core:2.1.0 which comes from https://github.com/grails/scaffolding-old and is archived. It was last released in 2019.
This also removes the confusion between org.grails:scaffolding-core:2.1.0 and org.grailsplugins:scaffolding:6.0.0-SNAPHOT, which are not related and do not reference each other.
https://github.com/grails/scaffolding does not use https://github.com/grails/scaffolding-old (org.grails:scaffolding-core), so the decision was made to put the code in the fields plugin. This also prevents a circular dependency reference.
The code and docs have been incorporated directly into fields so that the code can be maintained here. All git history has been maintained.
9 failing tests are currently ignored in this PR: 99c1dd9
This PR adds 116 passing tests for the scaffolding-old code.