Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Move Python and NodeJS pages #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arunkarthik-periyaswamy
Copy link

  • Moved the Python and NodeJS pages from Howtos to Developer's sections.
  • Updated the navigation menu in Developers section

 - Moved the Python and NodeJS pages from Howtos to Developer's sections.
 - Updated the navigation menu in Developers section
@arunkarthik-periyaswamy arunkarthik-periyaswamy changed the title Fix: Move Python and NodeJS pages. Addresses #12 Fix: Move Python and NodeJS pages #12 Jul 9, 2024
@arunkarthik-periyaswamy arunkarthik-periyaswamy changed the title Fix: Move Python and NodeJS pages #12 Fix: Move Python and NodeJS pages Jul 9, 2024
@arunkarthik-periyaswamy
Copy link
Author

Hello @nlsdvl can you please review this Addresses: #12

@nlsdvl
Copy link
Collaborator

nlsdvl commented Jul 10, 2024

Hello @arunkarthik-periyaswamy , thanks a lot for helping out on this one.

Can add the http redirections configuration to support the changes, eg. so that '/Howtos/python/' redirects to '/Developers/python/' ? I was looking at mkdocs-redirects to handle this.

I tried your changes localy, for python this works well.

For javascript, your changes creates a 'NodeJS' menu item alongside the 'javascript' one, I'm not sure about that.
The intent with the 'javascript' page is to provide an entry point to js developers that exposes the 2 options to work with GPAC 'NodeJS bindings' vs 'JSFilters plugins'.

I think we can just remove the Javascript page, and instead better emphasize the difference between NodeJS and JSFilters at the top of NodeJS page directly. The alternative would be to add NodeJS as a subsection of the Javascript menu somehow, that would make sense if this section is expected to grow over time. cc @jeanlf

@rbouqueau
Copy link
Member

@arunkarthik-periyaswamy No news on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants