Skip to content

Commit

Permalink
Merge pull request demarches-simplifiees#9316 from colinux/drop-dossi…
Browse files Browse the repository at this point in the history
…er-correction-columns

Tech: supprime la colonne dossier_corrections#kind
  • Loading branch information
colinux authored Jul 31, 2023
2 parents 0b46e64 + f2afe50 commit d331c47
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
2 changes: 0 additions & 2 deletions app/models/dossier_correction.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ class DossierCorrection < ApplicationRecord
belongs_to :dossier
belongs_to :commentaire

self.ignored_columns += ['kind']

validates_associated :commentaire

scope :pending, -> { where(resolved_at: nil) }
Expand Down
7 changes: 7 additions & 0 deletions db/migrate/20230713163641_remove_dossier_corrections_kind.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
class RemoveDossierCorrectionsKind < ActiveRecord::Migration[7.0]
def change
safety_assured do
remove_column :dossier_corrections, :kind, :string, default: 'incorrect', null: false
end
end
end
3 changes: 1 addition & 2 deletions db/schema.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#
# It's strongly recommended that you check this file into your version control system.

ActiveRecord::Schema[7.0].define(version: 2023_07_19_112020) do
ActiveRecord::Schema[7.0].define(version: 2023_07_18_113920) do
# These are extensions that must be enabled in order to support this database
enable_extension "pgcrypto"
enable_extension "plpgsql"
Expand Down Expand Up @@ -336,7 +336,6 @@
t.bigint "dossier_id", null: false
t.datetime "resolved_at", precision: 6
t.datetime "updated_at", precision: 6, null: false
t.string "kind", default: "correction", null: false
t.string "reason", default: "incorrect", null: false
t.index ["commentaire_id"], name: "index_dossier_corrections_on_commentaire_id"
t.index ["dossier_id"], name: "index_dossier_corrections_on_dossier_id"
Expand Down

0 comments on commit d331c47

Please sign in to comment.