Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .lagoon.env environment files. #10

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

steveworley
Copy link
Contributor

  • Adds a default .lagoon.env file to apply shield settings to Lagoon environments
  • Adds a .lagoon.env.production to disable shield in Lagoon.

   - Adds a default .lagoon.env file to apply shield settings to Lagoon environments
   - Adds a .lagoon.env.production to disable shield in Lagoon.
- Lagoon ineheritance defines `.lagoon.env.{$BRANCHNAME}` this would indicate that it will try and load .lagoon.env.master as this is our production branch.
@tobybellwood
Copy link

I'm concerned that using a published default user and pass (even as a fallback) might inadvertently leave some sites exposed - it'd be better to tie it to something more obscure, but still easily discoverable to trusted users. Maybe not setting a fallback, and instead relying on the setting coming in during provisioning?

@stooit
Copy link
Collaborator

stooit commented Aug 6, 2019

Can we also add docs that indicate what expected behaviour is (and how to determine user/pass).

I agree we shouldn't use published defaults, Ansible playbook should replace with something semi-random during provisioning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants