Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In testing this in
xml-crypto
it seems that it would be helpful to take innull
andundefined
as arguments, this way I don't have to have multiple checks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The definition of
SelectSingleReturnType
already includesundefined
, so it doesn't seem like there's a need to re-indicate that in the function signatures.SelectReturnType
doesn't includeundefined
, but I'm not sure I can see a good case for havingisArrayOfNodes
acceptundefined
.And
?
is for indicating a parameter that can be omitted completely, so that wouldn't be appropriate here.I think I can see the value of having these function accept
null
, but in that case, we should have a type for that to ensure uniformity and reduce duplication.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you prefer a new type of something like
type Nullable<T> = T | null
withNullable<SelectReturnType>
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think that would be good. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it occurred to me that we can probably just take
any
and narrow from there.