Skip to content

Commit

Permalink
Remove stray enum instance
Browse files Browse the repository at this point in the history
This `enum LOG_LEVELS` declaration also included a _variable name_,
causing RuntimeTools/appmetrics#641. It ended
up defining a `Log_levels` variable in every compilation unit that
included "Log.h", which then caused duplicate symbols at link time.

I don't know if there was a reason for this definition, but it looks
like a bug to me … if not, maybe it can be fixed by just putting a
`static` in front? idk.

Thanks!
  • Loading branch information
goto-bus-stop committed Aug 23, 2020
1 parent 2ac37f5 commit dd3cc6f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion org.eclipse.paho.mqtt.c/src/Log.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ enum LOG_LEVELS {
LOG_ERROR,
LOG_SEVERE,
LOG_FATAL,
} Log_levels;
};


/*BE
Expand Down

0 comments on commit dd3cc6f

Please sign in to comment.