Langmuir #52
Merged
Langmuir #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If merged in it will likely create issues with GA as YAML files for cases are not updated. In addition - are there configurations available for testing the new code. |
|
Regarding GA - it looks like all the checks completed successfully already? |
|
Yes - but entries are added to the YAML file. And if cases are not updated how can they read them - and use some of the new settings? |
|
I only added the new option quasi_eq_h15 to the existing entry
scnd_method:
https://github.com/gotm-model/code/pull/52/files#diff-c48e6470fdfda065545361404b8db40451c037e8559d552ffc59ae02c792a4e6R759
…On 6/21/24 15:48, Karsten Bolding wrote:
Yes - but entries are added to the YAML file. And if cases are not
updated how can they read them - and use some of the new settings?
—
Reply to this email directly, view it on GitHub
<#52 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC2RV6UIKC5QRYNTYC3WGS3ZIQVLVAVCNFSM6AAAAABJV5HFESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBSG44TEMZTGU>.
You are receiving this because you are subscribed to this
thread.Message ID: ***@***.***>
|
|
But none of the existing cases will use that setting! So the GA will not test the new code at all - or did I misunderstand something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are waiting for Knut to get 2FA I'll create the PR on his behalf.