Add missing default filtering id (WICG#1340)

gota0 · Jun 18, 2024 · cd0bb31 · cd0bb31
1 parent 7a4c43d
commit cd0bb31
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/ts/src/header-validator/trigger.test.ts b/ts/src/header-validator/trigger.test.ts
@@ -169,6 +169,18 @@ const testCases: jsontest.TestCase<Trigger>[] = [
       ]
     }`,
   },
+  {
+    name: 'missing-optional-filtering-id',
+    json: `{
+      "aggregatable_trigger_data": [{
+        "key_piece": "0x1",
+        "source_keys": ["a"]
+      }],
+      "aggregatable_values": {
+        "a": { "value": 3 }
+      }
+    }`,
+  },
   {
     name: 'or-filters',
     json: `{

diff --git a/ts/src/header-validator/validate-json.ts b/ts/src/header-validator/validate-json.ts
@@ -1226,8 +1226,10 @@ function aggregatableKeyValue(
     object: (j) =>
       struct(j, ctx, {
         value: field('value', aggregatableKeyValueValue),
-        filteringId: field('filtering_id', (j) =>
-          aggregatableKeyValueFilteringId(j, ctx, maxBytes)
+        filteringId: field(
+          'filtering_id',
+          (j) => aggregatableKeyValueFilteringId(j, ctx, maxBytes),
+          0n
         ),
       }),
   })