Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies are not resolved recursively #214

Open
T3sT3ro opened this issue Oct 11, 2022 · 1 comment
Open

Dependencies are not resolved recursively #214

T3sT3ro opened this issue Oct 11, 2022 · 1 comment
Labels
bug Something doesn't work as expected fixed in source Bug has been fixed in source-code, but has not been released yet priority I'm working on it, or will be soon
Milestone

Comments

@T3sT3ro
Copy link

T3sT3ro commented Oct 11, 2022

Description

It seems that ferium can't download a required chain of dependencies, and halts at depth 1. So mod A has optional dependency B, while B has required C, but when A prompts to install B as optional, the C is not pulled with B.

To Reproduce

  1. Create test profile for forge 1.16.5
  2. Add "Champions" mod: ferium add 307152
  3. When prompted for optional Craft Tweaker reply n
  4. When prompted for optional Game Stages (268655) reply y
  5. Check out the folder or run ferium list, to see:

$ ferium list
Champions CurseForge 307152
Game Stages CurseForge 268655

  1. Notice, that Game Stages requires Bookshelf (228525), but it was not downloaded.

manually removing GameStages and adding them via ferium add 268655 pulls the required Bookself properly

Software version

  • Ubuntu 22.04
  • Ferium 4.2.0
  • rustc 1.64.0 (a55dd71d5 2022-09-19)
  • cargo 1.64.0 (387270bc7 2022-09-16)

Additional information

It seems like ferium cannot recursively resolve dependencies.

Potential or ad-hoc sollutions and considerations

  • resolve dependencies recursively
  • print the chain in the tree like fashion with tabulation (minecraft mod dependencies should have reasonably shallow dependency tree)
  • add ferium list --verbose or ferium check command to print a list of installed mods along with their optional and required dependencies (and installed status) and so on in a tree
@T3sT3ro T3sT3ro added the bug Something doesn't work as expected label Oct 11, 2022
@theRookieCoder theRookieCoder changed the title Dependency chain is not resolved recursively - required dependencies of optional mods are not downloaded Dependencies are not resolved recursively Oct 12, 2022
@Boobies
Copy link

Boobies commented May 8, 2024

I would suggest expediting this ticket - not in an entitled way, obviously this isn't a day job, but in the sense that it should be given top priority over the other open issues. This is a particularly important features without which managing large collections of mods becomes a lot more impractical.

@theRookieCoder theRookieCoder added the priority I'm working on it, or will be soon label May 10, 2024
@theRookieCoder theRookieCoder removed the priority I'm working on it, or will be soon label Sep 26, 2024
@theRookieCoder theRookieCoder added this to the Version 5 milestone Nov 16, 2024
@theRookieCoder theRookieCoder added priority I'm working on it, or will be soon fixed in source Bug has been fixed in source-code, but has not been released yet labels Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something doesn't work as expected fixed in source Bug has been fixed in source-code, but has not been released yet priority I'm working on it, or will be soon
Development

Successfully merging a pull request may close this issue.

3 participants