Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems the feature of automately dependency resolve is missing? #438

Closed
1 task done
colinxu2020 opened this issue Nov 1, 2024 · 2 comments
Closed
1 task done

Seems the feature of automately dependency resolve is missing? #438

colinxu2020 opened this issue Nov 1, 2024 · 2 comments
Labels
bug Something doesn't work as expected duplicate The issue or pull request already exists

Comments

@colinxu2020
Copy link

Description

When I try to use ferium to add a mod, I've suprisely found that the dependency of the mod was still missing(while the mod itself was added), when I had a look at the help of add subcommand, there wasn't --dont-add-dependencies command(from #63).

I had a look at the changelog, but I can't found any clues about this, what had happened?

Steps to reproduce

  1. ferium add connector
  2. ferium upgrade
  3. The connector itself was in the correct place, but it's dependency was missing.

Operating System

Windows

Are you using the latest version of ferium?

  • I am using the latest version of ferium

Additional Information

No response

@colinxu2020 colinxu2020 added the bug Something doesn't work as expected label Nov 1, 2024
@theRookieCoder theRookieCoder added the duplicate The issue or pull request already exists label Nov 1, 2024
@theRookieCoder
Copy link
Collaborator

theRookieCoder commented Nov 1, 2024

I had a look at the changelog, but I can't found any clues about this, what had happened?

I failed to mention it in the changelog, but I removed the dependency feature because the previous implementation had some issues. One major issue is that it added the dependencies to the profile when the mod is added, and it does not consider dependencies tied with the specific version.

The solution for that would be to add dependencies during resolution-time, so when you're upgrade-ing (#99). Another issue was that dependencies were not resolved recursively, i.e. the dependencies of a dependency (and however farther the chain goes) would not be resolved (#214). I wanted to have a proper implementation of dependency resolution rather than have a half-baked one.

@theRookieCoder theRookieCoder closed this as not planned Won't fix, can't repro, duplicate, stale Nov 1, 2024
@colinxu2020
Copy link
Author

I had a look at the changelog, but I can't found any clues about this, what had happened?

I failed to mention it in the changelog, but I removed the dependency feature because the previous implementation had some issues. One major issue is that it added the dependencies to the profile when the mod is added, and it does not consider dependencies tied with the specific version.

The solution for that would be to add dependencies during resolution-time, so when you're upgrade-ing (#99). Another issue was that dependencies were not resolved recursively, i.e. the dependencies of a dependency (and however farther the chain goes) would not be resolved (#214). I wanted to have a proper implementation of dependency resolution rather than have a half-baked one.

Thinks for your quick response! I'm looking forward to the new dependency resolution system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something doesn't work as expected duplicate The issue or pull request already exists
Development

No branches or pull requests

2 participants