Fix handling of empty strings for set/set-attr scriptlets

Related issue: - uBlockOrigin/uBlock-issues#2729
gorhill · Jul 11, 2023 · 6e78ee0 · 6e78ee0
1 parent 4a83b80
commit 6e78ee0
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/assets/resources/scriptlets.js b/assets/resources/scriptlets.js
@@ -400,7 +400,7 @@ function setConstantCore(
  cValue = true;
  } else if ( cValue === 'null' ) {
  cValue = null;
- } else if ( cValue === "''" ) {
+ } else if ( cValue === "''" || cValue === '' ) {
  cValue = '';
  } else if ( cValue === '[]' ) {
  cValue = [];
@@ -2994,12 +2994,11 @@ function setAttr(
 ) {
  if ( typeof selector !== 'string' ) { return; }
  if ( selector === '' ) { return; }
- if ( value === '' ) { return; }
 
  const validValues = [ '', 'false', 'true' ];
  let copyFrom = '';
 
- if ( validValues.includes(value) === false ) {
+ if ( validValues.includes(value.toLowerCase()) === false ) {
  if ( /^\d+$/.test(value) ) {
  const n = parseInt(value, 10);
  if ( n >= 32768 ) { return; }